chore: Bump Snaps and related dependencies by Mrtenz · Pull Request #28140 · MetaMask/metamask-mobile

Mrtenz · 2026-03-31T08:40:34Z

Description

Major bump of @metamask/snaps-controllers and related packages. This mainly handles breaking changes, there shouldn't be any changes in functionality. Changes include:

Standardisation of action and event names (e.g., GetSnap is now SnapControllerGetSnapAction).
- Some method names have changes as well (e.g., SnapController:get is now SnapController:getSnap).
The JsonSnapsRegistry is now named SnapRegistryController for consistency with other Snap controllers.
- This includes a migration to copy the previous state to the new controller state.
The MultichainRouter is now named MultichainRoutingService.
snap_getCurrencyRate and snap_experimentalProviderRequest were removed. These were undocumented and deprecated, and shouldn't be used by any Snaps.

Changelog

CHANGELOG entry: Remove deprecated Snap methods snap_getCurrencyRate and snap_experimentalProviderRequest.

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Broad dependency upgrade with widespread renames of controller/messenger action strings and a persisted-state migration; main risk is runtime breakage if any call sites or stored state keys were missed.

Overview
Updates to @metamask/snaps-controllers (and related packages) are wired through the app, including standardized action/event types and renamed RPC/messenger action strings (e.g. SnapController:get �� SnapController:getSnap).

Renames JsonSnapsRegistry �� SnapRegistryController and MultichainRouter �� MultichainRoutingService across Engine initialization, messengers, and Snap/multichain middleware, and adds migration 129 to move persisted SnapsRegistry state under SnapRegistryController.

Adjusts a few controller inits/tests to match updated upstream APIs (e.g., GatorPermissionsController now uses a config object and no longer relies on isGatorPermissionsFeatureEnabled; BridgeStatusController init stops passing transaction helper fns and instead expands its messenger delegation). Removes deprecated Snap permission snap_experimentalProviderRequest from the allowed method list.

^{Written by Cursor Bugbot for commit da37ac3. This will update automatically on new commits. Configure here.}

socket-security · 2026-03-31T08:42:56Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
npm/@metamask/keyring-internal-api@10.0.0 ⏵ 10.0.1			⁺²
npm/@metamask/logging-controller@8.0.0 ⏵ 8.0.1			⁺²
npm/@metamask/multichain-transactions-controller@7.0.2 ⏵ 7.0.4			⁺¹
npm/@metamask/keyring-snap-client@8.2.0 ⏵ 8.2.1			⁺³
npm/@metamask/accounts-controller@37.1.0 ⏵ 37.1.1			⁺¹
npm/@metamask/snaps-execution-environments@11.0.1 ⏵ 11.0.2	⁺¹	⁺¹	⁺¹
npm/@metamask/signature-controller@39.1.0 ⏵ 39.1.2			⁺¹
npm/@metamask/bridge-status-controller@70.0.3 ⏵ 70.0.4
npm/@metamask/account-tree-controller@6.0.0 ⏵ 7.0.0			⁺¹
npm/@metamask/bridge-controller@69.2.3 ⏵ 70.0.0	⁺¹	⁺¹
npm/@metamask/multichain-account-service@8.0.0 ⏵ 8.0.1			⁺¹
npm/@metamask/transaction-pay-controller@19.0.0 ⏵ 19.0.1	⁺¹	⁺¹	⁺¹
npm/@metamask/profile-sync-controller@28.0.1 ⏵ 28.0.2			⁺¹
npm/@metamask/gator-permissions-controller@2.1.1 ⏵ 3.0.0		⁺¹	⁺¹
npm/@metamask/eth-snap-keyring@20.0.0

View full report

socket-security · 2026-03-31T08:42:58Z

Warning

MetaMask internal reviewing guidelines:

Do not ignore-all
Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
@SocketSecurity ignore npm/PACKAGE@VERSION

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		Potential code anomaly (AI signal): npm `@metamask/transaction-controller` is 100.0% likely to have a medium risk anomaly Notes: The code performs straightforward signature verification using ethers.js, returning true when the recovered signer matches the provided publicKey. While generally safe, the silent catch and potential mismatch between data formatting and signing process should be addressed to avoid silent failures. Overall, a benign utility with moderate input-format sensitivity. Confidence: 1.00 Severity: 0.60 From: `?` → `npm/@metamask/eip-5792-middleware@2.0.0` → `npm/@metamask/transaction-controller@61.3.0` ℹ Read more on: This package \| This alert \| What is an AI-detected potential code anomaly? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@metamask/transaction-controller@61.3.0`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

- Removes GATOR_PERMISSIONS_ENABLED - Presently configured with hardcoded supportedPermissionTypes: []

github-actions · 2026-03-31T09:43:26Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…r messenger

app/core/Engine/messengers/multichain-assets-controller-messenger/types.ts

app/core/Engine/controllers/multichain-router/constants.ts

github-actions · 2026-03-31T11:54:43Z

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main or a release branch (base: test/core-pr-8245-testdrive)

All E2E tests pre-selected.

View GitHub Actions results

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

cursor · 2026-03-31T12:02:07Z

app/core/Engine/controllers/gator-permissions-controller/gator-permissions-controller-init.ts

-    },
+    messenger: controllerMessenger,
+    config: createGatorPermissionsConfig(),
+    state: persistedState.GatorPermissionsController,


Missing state migration for GatorPermissionsController schema change

Medium Severity

The GatorPermissionsController state schema changed completely (old: gatorPermissionsMapSerialized, gatorPermissionsProviderSnapId, isGatorPermissionsEnabled; new: grantedPermissions, lastSyncedTimestamp, pendingRevocations), but no migration was added to handle this. The old init code explicitly merged defaults with persisted state via generateDefaultGatorPermissionsControllerState(), but the new code passes persistedState.GatorPermissionsController directly to the constructor. On upgrade, existing users will have old-format state passed to the v3.0.0 controller. A migration was added for the SnapsRegistry → SnapRegistryController key rename, but the analogous GatorPermissionsController internal state shape change was not addressed.

Additional Locations (1)

app/store/migrations/129.ts#L1-L28

github-actions · 2026-03-31T12:14:19Z

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

sonarqubecloud · 2026-03-31T12:23:25Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.5% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube Cloud

Bump dependencies and update resolutions

c776b51

metamaskbot added the team-core-platform Core Platform team label Mar 31, 2026

github-actions bot added the size-S label Mar 31, 2026

Mrtenz added 3 commits March 31, 2026 10:54

Rename instances of SnapsRegistry to SnapRegistryController

a3ca2c1

Handle breaking changes in snap-controller

10fd818

Rename instances of MultichainRouter to MultichainRoutingService

73cea6c

github-actions bot added size-L and removed size-S labels Mar 31, 2026

Mrtenz and others added 3 commits March 31, 2026 11:31

Handle breaking changes in execution service

19513ec

Fix more breaking SnapController changes

9c7d94a

Handle breaking changes in gator-permissions-controller

f30068a

- Removes GATOR_PERMISSIONS_ENABLED - Presently configured with hardcoded supportedPermissionTypes: []

github-actions bot added size-XL and removed size-L labels Mar 31, 2026

Mrtenz added 7 commits March 31, 2026 11:56

Fix remaining type errors

57be151

Fix unit tests

c6d4bf7

Update engine fixture

a60ce7a

Remove snap_experimentalProviderRequest

b48e665

Add KeyringController:signTypedMessage to transaction pay controlle…

7eb39de

…r messenger

Add migration for SnapRegistryController state

48e4209

Update state log snapshots

3f4987e

Mrtenz marked this pull request as ready for review March 31, 2026 11:38

Mrtenz requested review from a team as code owners March 31, 2026 11:38

Mrtenz requested a review from a team as a code owner March 31, 2026 11:38

cursor bot reviewed Mar 31, 2026

View reviewed changes

app/core/Engine/messengers/multichain-assets-controller-messenger/types.ts Outdated Show resolved Hide resolved

Remove unused types

3405baa

cursor bot reviewed Mar 31, 2026

View reviewed changes

app/core/Engine/controllers/multichain-router/constants.ts Outdated Show resolved Hide resolved

Remove more unused types

da37ac3

cursor bot reviewed Mar 31, 2026

View reviewed changes

Mrtenz merged commit 30b93b5 into test/core-pr-8245-testdrive Mar 31, 2026
182 of 193 checks passed

Mrtenz deleted the mrtenz/bump-snaps-packages branch March 31, 2026 13:01

github-actions bot locked and limited conversation to collaborators Mar 31, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Bump Snaps and related dependencies#28140

chore: Bump Snaps and related dependencies#28140
Mrtenz merged 16 commits intotest/core-pr-8245-testdrivefrom
mrtenz/bump-snaps-packages

Mrtenz commented Mar 31, 2026 •

edited by cursor bot

Loading

Uh oh!

socket-security bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

socket-security bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

sonarqubecloud bot commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Mrtenz commented Mar 31, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

socket-security bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026

🔍 Smart E2E Test Selection

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 31, 2026

Choose a reason for hiding this comment

Missing state migration for GatorPermissionsController schema change

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

sonarqubecloud bot commented Mar 31, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mrtenz commented Mar 31, 2026 •

edited by cursor bot

Loading

socket-security bot commented Mar 31, 2026 •

edited

Loading

socket-security bot commented Mar 31, 2026 •

edited

Loading